Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

Fix encoding error with location and refresh headers - #33763

Merged
kodiakhq[bot] merged 3 commits into
vercel:canaryfrom
timneutkens:fix/location-header-issue
Jan 28, 2022
Merged

Fix encoding error with location and refresh headers#33763
kodiakhq[bot] merged 3 commits into
vercel:canaryfrom
timneutkens:fix/location-header-issue

Conversation

@timneutkens

@timneutkens timneutkens commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

Fixes the merge conflicts in #27003

Fixes #24977
Fixes #24047
Closes #27003

Co-Authored-By: Jamie 5964236+jamsinclair@users.noreply.github.com

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@timneutkens @jamsinclair
Fix encoding error with location and refresh headers
8ff428b 
Fixes the merge conflicts in vercel#27003

Fixes vercel#24977
Fixes vercel#24047
Closes vercel#27003

Co-Authored-By: Jamie <5964236+jamsinclair@users.noreply.github.com>
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 28, 2022
@timneutkens timneutkens mentioned this pull request Jan 28, 2022
Closed
2 tasks done
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

ijjk commented Jan 28, 2022

Copy link
Copy Markdown
Member

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
buildDuration 16.5s 17s ⚠️ +500ms
buildDurationCached 4.2s 4.2s -36ms
nodeModulesSize 358 MB 358 MB ⚠️ +599 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.256 4.189 -0.07
/ avg req/sec 587.4 596.73 +9.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.29 2.276 -0.01
/error-in-render avg req/sec 1091.87 1098.45 +6.58
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.4 kB 14.4 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
index.html gzip 530 B 530 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
buildDuration 21.4s 21.6s ⚠️ +201ms
buildDurationCached 4.3s 4.2s -56ms
nodeModulesSize 358 MB 358 MB ⚠️ +599 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.097 4.154 ⚠️ +0.06
/ avg req/sec 610.18 601.79 ⚠️ -8.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.281 2.269 -0.01
/error-in-render avg req/sec 1096.23 1101.65 +5.42
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/location-header-issue Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 315a9de

@kodiakhq
kodiakhq Bot merged commit f104e91 into vercel:canary Jan 28, 2022
@timneutkens timneutkens mentioned this pull request Jan 31, 2022
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes
@ijjk ijjk Awaiting requested review from ijjk
@shuding shuding Awaiting requested review from shuding

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

3 participants

@timneutkens @ijjk @huozhi