Repository navigation
Adding Asset Component for Rich Text Renderer - #32503
Merged
kodiakhq[bot] merged 8 commits intoJan 7, 2022
Merged
Conversation
This adds a custom React component which renders an inline asset from a rich text field
davidfateh
requested review from
ijjk,
leerob,
shuding and
timneutkens
as code owners
December 14, 2021 16:14
Contributor
Author
|
Hello @leerob, I believe you spoke with @stefanjudis about these changes. Let me know what you think about them. Also, let me know if there are version numbers that need updating in order for this work to be code-complete. Thank you! |
leerob
reviewed
Dec 16, 2021
leerob
left a comment
Contributor
There was a problem hiding this comment.
Updating dependencies would be amazing!
Contributor
Author
|
@leerob Hey there, happy new year! I believe I've made all the changes you were talking about. When you have a sec, could you take another look and make sure everything looks good on your end? |
teleaziz
added a commit
to teleaziz/next.js
that referenced
this pull request
Jan 11, 2022
…into cms-builder-io-example * 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits) drop dynamic import with `ssr: false` on server-side (vercel#32606) next-swc: fix ssg code elimination when used in render (vercel#32709) Add Caveats section to custom error page (vercel#33160) v12.0.8-canary.20 Allow dependencies to use environment variables in middlewares (vercel#33141) use a separate webpack runtime for middleware (vercel#33134) No info on environment variables in the src folder (vercel#33110) (vercel#33136) docs: minor text-copy cleanup (vercel#33120) Update swc (vercel#33063) Update next.config.js (vercel#33091) Adding Asset Component for Rich Text Renderer (vercel#32503) Update using-mdx.md (vercel#33077) v12.0.8-canary.19 Fix middleware at root in standalone mode (vercel#33053) Add util for generating new tests/error documents (vercel#33001) Remove extra config from tailwind example (vercel#33062) Fix link for Next.js Analytics in docs (vercel#33049) Bump `@vercel/nft` to 0.17.2 (vercel#33048) Update deployment documentation. (vercel#32006) v12.0.8-canary.18 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accomplishes 2 things:
Feature
Documentation / Examples
yarn lint