Pewarta Proxy

📋 Server Request & Proxy Logs

Loading active proxy settings...
Developed by Khairul Adha (adhexa.id)
Mengambil log server...

⚙️ Pengaturan Proxy Target

Skip to content

Fixes for inline embedding data in the web runtime - #32471

Merged
shuding merged 5 commits into
vercel:canaryfrom
shuding:shu/c75a
Dec 13, 2021
Merged

Fixes for inline embedding data in the web runtime#32471
shuding merged 5 commits into
vercel:canaryfrom
shuding:shu/c75a

Conversation

@shuding

@shuding shuding commented Dec 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

ReactDOMServer.renderToString doesn't exist in react-dom/cjs/react-dom-server.browser, so I'll just write the result there to make it easier.

Another fix is for req.tee(), which doesn't seem reliable with our polyfill. One of the resulting branches will not receive any data so the entire request hangs there. As a workaround I'm using 2 transform streams to manually fork the original readable stream.

Related to #32330.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 13, 2021
@shuding
shuding marked this pull request as ready for review December 13, 2021 22:22
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

ijjk commented Dec 13, 2021

Copy link
Copy Markdown
Member

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/c75a Change
buildDuration 17.8s 18.1s ⚠️ +339ms
buildDurationCached 3.4s 3.9s ⚠️ +474ms
nodeModulesSize 350 MB 350 MB ⚠️ +1.08 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/c75a Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.866 3.033 ⚠️ +0.17
/ avg req/sec 872.32 824.29 ⚠️ -48.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.286 1.411 ⚠️ +0.13
/error-in-render avg req/sec 1943.36 1771.84 ⚠️ -171.52
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/c75a Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/c75a Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/c75a Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/c75a Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/c75a Change
index.html gzip 532 B 532 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/c75a Change
buildDuration 20.4s 20.1s -274ms
buildDurationCached 3.3s 3.4s ⚠️ +37ms
nodeModulesSize 350 MB 350 MB ⚠️ +1.08 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/c75a Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.902 2.882 -0.02
/ avg req/sec 861.48 867.51 +6.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.284 1.364 ⚠️ +0.08
/error-in-render avg req/sec 1946.38 1832.59 ⚠️ -113.79
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/c75a Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.2 kB 74.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/c75a Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/c75a Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/c75a Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/c75a Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 631f55c

@shuding
shuding merged commit 8f9aed6 into vercel:canary Dec 13, 2021
@shuding
shuding deleted the shu/c75a branch December 13, 2021 23:48
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhi huozhi huozhi approved these changes
@ijjk ijjk ijjk approved these changes
@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuding @ijjk @huozhi