Repository navigation
feat(docs): always expanding collapsible sidebar menus under docs - #5608
Conversation
|
Thanks for the PR, @santoshyadavdev! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks great so far! Just throwing an idea around ✨
| { | ||
| label: 'Architecture', | ||
| type: 'category', | ||
| collapsed: false, |
There was a problem hiding this comment.
What do you think about switching these to:
| collapsed: false, | |
| collapsible: false, |
Reasoning: since there are so few menu options, I can't think of any reason why someone would want to collapse them. So the buttons to toggle collapse them are unnecessary UI.
There was a problem hiding this comment.
Yeah makes sense, so no collapsible pane at all.
Let me try it.
There was a problem hiding this comment.
this is how it looks after this
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
💯 thanks @santoshyadavdev!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5608 +/- ##
==========================================
+ Coverage 91.59% 91.63% +0.03%
==========================================
Files 369 134 -235
Lines 12391 1506 -10885
Branches 3613 226 -3387
==========================================
- Hits 11350 1380 -9970
+ Misses 685 62 -623
+ Partials 356 64 -292
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR Checklist
Overview